fix: move blind-sign tests to 7.14.0 report section#184
Closed
BitHighlander wants to merge 1 commit intokeepkey:masterfrom
Closed
fix: move blind-sign tests to 7.14.0 report section#184BitHighlander wants to merge 1 commit intokeepkey:masterfrom
BitHighlander wants to merge 1 commit intokeepkey:masterfrom
Conversation
E16/E17 (blind_sign_blocked, blind_sign_allowed) were in the Ethereum
section (min_fw 7.0.0), causing them to appear as FAILED on pre-7.14
builds despite requires_firmware("7.14.0") skipping them at runtime.
Relocated to EVM Clear-Signing section (V, min_fw 7.14.0) as V8/V9
so the report only includes them for firmware >= 7.14.0.
Contributor
Author
|
Moving to upstream branch instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
7.0.0), causing them to show as FAILED on pre-7.14 firmware buildsrequires_firmware("7.14.0")which skips them at runtime, but the report generator still counted them since the Ethereum section is active for any firmware >= 7.0.07.14.0) so the report only includes them for firmware >= 7.14.0Test plan
generate-test-report.py --fw-version=7.10.0— E16/E17 should no longer appeargenerate-test-report.py --fw-version=7.14.0— V8/V9 should appear in EVM Clear-Signing section